Prevent Links in Text Fields to Foil Spammers

As soon as you allow user-generated content in those emails, your application becomes an interesting target for email spammers. This is due to these nefarious people, and their robot armies, abusing the free text you allow legitimate users to enter.

Email clients like Apple Mail and Gmail automatically highlight strings of text that look like web addresses, so by simply inserting strings that resemble web addresses, hackers can use text fields to direct users to nefarious websites. They don’t even have to inject HTML.

Instead of…

…allowing naughty spammers to use the email sending functionality of your application:

<%= form_for :invitee do |f| %>
  Email: <%= f.text_field :email %>
  Message : <%= f.text_field :message %>
  <%= f.submit "Send Email" %>
<% end %>

Always…

…use a validation to prevent the insertion of web addresses into your text fields.

<%= form_for :invitee do |f| %>
  Email: <%= f.text_field :email %>
  Message : <%= f.text_field :message %>
  <%= f.submit "Send Email" %>
<% end %>

validators/no_urls_validator.rb

class NoUrlsValidator < ActiveModel::EachValidator
  def validate_each(record, attribute, value)
    return if value.blank?

    if value.match?(%r{(http|\w+\.\w+\/?)})
      record.errors[attribute] << (options[:message] || "looks like it contains a web address")
    end
  end
end

app/models/invitee.rb

class Invitee
  # ...
  validates :message, no_urls: true
  # ...
end

But why?

This isn’t an obvious issue, but definitely a vector of attack that spammers have uncovered and will exploit. If your application allows sending of any email containing user-entered free text, even if the text is short, you are a target.

This is most acute if you allow users to send emails from your application before taking a payment. If you do not require a valid credit card before any email sending, a spammer can automatically run a script to sign up for a free trial and send links from your application thousands of times in a surprisingly short amount of time.

Sending lots of spam from your application can have a bad effect on the overall deliverability of email from your application and even your domain. You don’t want that to happen.

While protecting browsers from user-generated HTML and JavaScript has been a part of Rails’ rendering since the beginning, email clients automatically linking website-ish, non-HTML, text happens beyond our application’s boundaries.

If you validate your user-entered text, you’ll be less of a target for this spam technique.

Why not?

The regular expression I’ve used in the validator is pretty naïve and may result in false positives. It rejects any string containing “http” or any two words joined by a full stop character: “like.this”.

You might opt to change the regular expression to match a more specific pattern.

Or, instead of rejecting the text with a validation, and sending an error message to the user, you might choose to fix the text in a callback, perhaps adding a space after every full stop:

"like.this".tr(".", ". ")
#=> "like. this"

Additionally, where applicable, you might want to find another way to restrict text input or features until your users have become paying customers—the requirement of a credit card is often a good barrier to spammers.